Add unmount method in UIManagerMountHook and use it to notify not intersecting state in IntersectionObserver #45186
+61
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59061136 |
…ersecting state in IntersectionObserver (facebook#45186) Summary: Pull Request resolved: facebook#45186 Changelog: [internal] (this is an internal change because `IntersectionObserver` hasn't been released yet). When testing IntersectionObserver, I realized that it wasn't triggering notifications for elements not intersecting when the surface that contained them was completely deallocated. This is unexpected because IntersectionObserver notifications are delivered when the element is removed from the root, but not when the root itself is removed. This fixes that behavior by: 1. Adding a method in `UIManagerMountHooks` to get a notification about the surface being unmounted. This is necessary to keep the API backwards compatible. 2. Using that method in `IntersectionObserverManager` to notify all observers (and report a change if necessary). Differential Revision: D59061136
|
This pull request was exported from Phabricator. Differential Revision: D59061136 |
rubennorte
force-pushed
the
export-D59061136
branch
from
550b325
to
49ffbec
Compare
Base commit: 0fb6110 |
|
This pull request has been merged in 39b33f1. |
|
This pull request was successfully merged by @rubennorte in 39b33f1. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
(this is an internal change because
IntersectionObserverhasn't been released yet).When testing IntersectionObserver, I realized that it wasn't triggering notifications for elements not intersecting when the surface that contained them was completely deallocated.
This is unexpected because IntersectionObserver notifications are delivered when the element is removed from the root, but not when the root itself is removed.
This fixes that behavior by:
UIManagerMountHooksto get a notification about the surface being unmounted. This is necessary to keep the API backwards compatible.IntersectionObserverManagerto notify all observers (and report a change if necessary).Differential Revision: D59061136